Database access docs overhaul #5643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benarent
reviewed
Feb 23, 2021
benarent
reviewed
Feb 23, 2021
benarent
reviewed
Feb 23, 2021
benarent
reviewed
Feb 23, 2021
benarent
reviewed
Feb 23, 2021
benarent
reviewed
Feb 23, 2021
benarent
reviewed
Feb 23, 2021
benarent
reviewed
Feb 23, 2021
r0mant
force-pushed
the
roman/dbdocs2
branch
2 times, most recently
from
cb941cd to
1edc633
Compare
|
@benarent Addressed your comments, PTAL. |
travelton
reviewed
Feb 25, 2021
|
@travelton Addressed your comments, thanks! |
travelton
approved these changes
Feb 26, 2021
benarent
reviewed
Feb 26, 2021
| --db-uri=db.example.com:3306 | ||
| ``` | ||
|
|
||
| ### Start Database Service with Config File |
There was a problem hiding this comment.
+1 for this section. As I was setting up Teleport Application Access we could do something similar for it.
There was a problem hiding this comment.
Yeah, AAP docs are next in line :)
benarent
reviewed
Feb 26, 2021
benarent
reviewed
Feb 26, 2021
benarent
approved these changes
Feb 26, 2021
r0mant
force-pushed
the
roman/dbdocs2
branch
from
f7bedde to
22f860c
Compare
klizhentas
requested changes
Feb 26, 2021
r0mant
force-pushed
the
roman/dbdocs2
branch
from
22f860c to
fb88577
Compare
|
@klizhentas Think I've address all of your comments: fb88577 and 987c482 if you want to take a look at the commits. |
klizhentas
approved these changes
Feb 27, 2021
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big overhaul of database access docs. What previously was a single "preview" page, is now split into separate pages under a new top-level section. Below is a brief description of changes.
Database access content hub
The "Database Access" page in the first "Introduction" section will serve as a content hub for database access, with brief description, demo video and links leading to other resources. K8s/app access pages will eventually do the same.
New top-level section
With the following hierarchy.
New content
There's always more content to potentially add but I think this will do for the initial release.